Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting segment overrides is enforced by "Manage segments" permission in the frontend #5131

Closed
3 of 4 tasks
rolodato opened this issue Feb 18, 2025 · 0 comments · Fixed by #5134
Closed
3 of 4 tasks
Assignees
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard

Comments

@rolodato
Copy link
Member

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

See reproduction steps.

Steps To Reproduce

  1. Grant a user permissions to manage segment overrides in one environment, but not manage segments at the project level
  2. Try to edit an already-created segment override in this environment

Result: segment overrides can be created and edited, but not deleted. The tooltip is incorrect as "Manage segment overrides" does grant permission to delete existing overrides.

Image

Expected behavior

Don't require "manage segments" permission to delete existing segment overrides.

Screenshots

No response

@rolodato rolodato added bug Something isn't working front-end Issue related to the React Front End Dashboard labels Feb 18, 2025
@kyle-ssg kyle-ssg linked a pull request Feb 19, 2025 that will close this issue
4 tasks
@kyle-ssg kyle-ssg self-assigned this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants