Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log Hubspot cookie creation #4778

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

zachaysan
Copy link
Contributor

Changes

Debugging form creation and it's not clear why forms aren't being created.

How did you test this code?

Relying on existing tests.

@zachaysan zachaysan requested a review from a team as a code owner October 28, 2024 18:50
@zachaysan zachaysan requested review from matthewelwell and removed request for a team October 28, 2024 18:50
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 1:21pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 1:21pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 1:21pm

@zachaysan zachaysan requested review from khvn26 and removed request for matthewelwell October 28, 2024 18:50
@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4778 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4778 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4778 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4778 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4778 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4778 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Uffizzi Preview deployment-57701 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (56a266d) to head (19abb15).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4778   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files        1174     1175    +1     
  Lines       40846    40904   +58     
=======================================
+ Hits        39744    39802   +58     
  Misses       1102     1102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 960def4 Oct 29, 2024
35 checks passed
@matthewelwell matthewelwell deleted the feat/log_hubspot_cookie_creation branch October 29, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants