fix(sales-dashboard): prevent 500 error when user doesn't exist on sales dashboard search

[matthewelwell]

Changes

Prevents a 500 error when searching the sales dashboard for a user email address that doesn't exist.

Also adds functionality to search by a domain, which will now search across all users with that domain and return any organisations that belong to users with that domain.

Note that the reason this can't be simplified to e.g. users__email__endswith is because of this PR: #4377.

How did you test this code?

Added a new unit test.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2024 1:01pm
flagsmith-frontend-preview	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2024 1:01pm
flagsmith-frontend-staging	⬜️ Ignored (Inspect)	Visit Preview		Oct 25, 2024 1:01pm

[github-actions]

Docker builds report

Image	Build Status	Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4757	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-4757	Finished ✅	Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4757	Finished ✅	Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4757	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-4757	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith:pr-4757	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4757	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith:pr-4757	Finished ✅	Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4757	Finished ✅	Results ✅

[github-actions]

Uffizzi Ephemeral Environment Deploying

☁️ https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4757

⚙️ Updating now by workflow run 11518746962.

What is Uffizzi? Learn more!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (6d2ab58) to head (b7d395f).
Report is 15 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4757   +/-   ##
=======================================
  Coverage   97.21%   97.22%           
=======================================
  Files        1172     1172           
  Lines       40535    40560   +25     
=======================================
+ Hits        39408    39434   +26     
+ Misses       1127     1126    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rolodato]

grabs the domain and searches for organisations belonging to users with that domain.

This behaviour is super useful, but I don't like it as a fallback, especially for public domains such as gmail.com, icloud.com, etc. Returning 0 results when searching for a specific user in this case is desirable.

Instead, we could make this explicit when searching for a domain, like @example.com, which would return all organisations that have users with a domain of example.com.

[matthewelwell]

grabs the domain and searches for organisations belonging to users with that domain.

This behaviour is super useful, but I don't like it as a fallback, especially for public domains such as gmail.com, icloud.com, etc. Returning 0 results when searching for a specific user in this case is desirable.

Instead, we could make this explicit when searching for a domain, like @example.com, which would return all organisations that have users with a domain of example.com.

Yeah, I tend to agree. I was just being lazy. I'll update.

[rolodato]

Left a minor suggestion, either way it's an improvement and happy to ship it as-is 👍