Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Manage tags permission #4615

Merged
merged 4 commits into from
Oct 2, 2024
Merged

feat: Manage tags permission #4615

merged 4 commits into from
Oct 2, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Based on the feature flag manage_tags_permission, this will require MANAGE_TAGS rather than ADMIN permissions for creating,editing and removing tags

How did you test this code?

Validate that the permission variables are set correctly, permission doesn't exist yet

@kyle-ssg kyle-ssg requested a review from a team as a code owner September 10, 2024 15:29
@vercel Vercel
Copy link

vercel bot commented Sep 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 6:01pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 6:01pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 6:01pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4615 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4615 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4615 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4615 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4615 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4615 Finished ✅ Results ✅

@github-actions github-actions bot added the feature New feature or request label Sep 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 10, 2024 •
edited
Loading

Uffizzi Preview deployment-56102 was deleted.

@matthewelwell
Copy link
Contributor

matthewelwell commented Sep 16, 2024 •
edited
Loading

The PR to add the API logic is here. We should make sure that the API PR is merged and released first as it doesn't change the current behaviour (since it will fall back to just using project admin is a user doesn't have the MANAGE_TAGS permission).

@kyle-ssg
Copy link
Member Author

kyle-ssg commented Sep 17, 2024 •
edited
Loading

@matthewelwell Actually that's fine since it's under the flag manage_tags_permission. Plus frontend would do the same too so I guess it's actually backwards compatible

@flagsmith Flagsmith
Copy link

flagsmith bot commented Sep 17, 2024

Flagsmith feature linked: manage_tags_permission
Default Values:

Environment Enabled Value Last Updated (UTC)
Production ❌ Disabled 2024-09-10 13:27:43
Staging ❌ Disabled 2024-09-10 13:27:43
Demo ❌ Disabled 2024-09-10 13:27:43
Self hosted defaults ❌ Disabled 2024-09-10 13:27:43

@flagsmith Flagsmith
Copy link

flagsmith bot commented Sep 17, 2024

Flagsmith Feature manage_tags_permission has been updated:

Environment Enabled Value Last Updated (UTC)
Staging ✅ Enabled 2024-09-17 15:57:31

@flagsmith Flagsmith
Copy link

flagsmith bot commented Oct 1, 2024

Flagsmith Feature manage_tags_permission has been updated:

Segment flagsmith_team values:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-10-01 14:05:35

@matthewelwell
Copy link
Contributor

matthewelwell commented Oct 1, 2024 •
edited
Loading

@kyle-ssg the tooltip on the 'Add Tag' button still refers to the 'Admin' permission.

image

@matthewelwell matthewelwell mentioned this pull request Oct 1, 2024
Merged
@kyle-ssg kyle-ssg requested a review from matthewelwell October 1, 2024 16:08
@kyle-ssg
Copy link
Member Author

kyle-ssg commented Oct 1, 2024

@matthewelwell done

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 1, 2024
@kyle-ssg
Merge branch 'refs/heads/main' into feat/manage-tags-permission
e41f6cb 
# Conflicts:
#	frontend/web/components/SegmentOverrides.js
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Oct 1, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 2, 2024
Merged via the queue into main with commit b3da659 Oct 2, 2024
31 checks passed
@kyle-ssg kyle-ssg deleted the feat/manage-tags-permission branch October 2, 2024 16:24
@flagsmithdev flagsmithdev mentioned this pull request Oct 2, 2024
Merged
@flagsmith Flagsmith
Copy link

flagsmith bot commented Oct 4, 2024

Flagsmith Feature manage_tags_permission has been updated:

Environment Enabled Value Last Updated (UTC)
Production ✅ Enabled 2024-10-04 09:27:06

@flagsmith Flagsmith
Copy link

flagsmith bot commented Oct 30, 2024

Flagsmith Feature manage_tags_permission has been updated:

Environment Enabled Value Last Updated (UTC)
Demo ✅ Enabled 2024-10-30 19:10:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell