-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app_analytics): Add cache for feature evaluation #4418
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
Docker builds report
|
Uffizzi Preview |
a330417
to
136b7f6
Compare
136b7f6
to
a0b390f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4418 +/- ##
==========================================
+ Coverage 96.83% 96.89% +0.06%
==========================================
Files 1165 1172 +7
Lines 38621 39082 +461
==========================================
+ Hits 37398 37868 +470
+ Misses 1223 1214 -9 ☔ View full report in Codecov by Sentry. |
a0b390f
to
b4cc71e
Compare
b4cc71e
to
689296f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions and two nitpicks. Otherwise, looks good.
e14c3d7
to
689296f
Compare
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Create and use cache to batch feature evaluation calls to reduce load on task processor
How did you test this code?
Added unit test