Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logic to handle subscriptions in trial #4404

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

API component for #604

This PR handles the subscription status "in_trial". When the trial switches to "active", "non_renewing" or "cancelled", the rest of the logic / tests should cover that behaviour.

How did you test this code?

Updated existing unit test.

@matthewelwell matthewelwell requested a review from a team as a code owner July 29, 2024 09:47
@matthewelwell matthewelwell requested review from zachaysan and removed request for a team July 29, 2024 09:47
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jul 29, 2024 9:47am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jul 29, 2024 9:47am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jul 29, 2024 9:47am

@matthewelwell matthewelwell changed the title Add logic to handle subscriptions in trial fix: add logic to handle subscriptions in trial Jul 29, 2024
@github-actions github-actions bot added the api Issue related to the REST API label Jul 29, 2024
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4404 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4404 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4404 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4404 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4404 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4404 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Uffizzi Preview deployment-54733 was deleted.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (114d0c3) to head (69b663c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4404   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files        1166     1166           
  Lines       38675    38676    +1     
=======================================
+ Hits        37453    37454    +1     
  Misses       1222     1222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit c10e012 Jul 29, 2024
34 checks passed
@matthewelwell matthewelwell deleted the fix/handle-free-trials branch July 29, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants