Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backend support for Organisation-level integrations #4400

Merged
merged 10 commits into from
Aug 29, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 26, 2024

Contributes to #4391, #4434

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This adds base classes to enable organisation-level audit log integrations, and adds Grafana as one.

How did you test this code?

Added numerous new unit tests to test new code paths and some of the old uncovered ones.

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 5:51pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 5:51pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Aug 28, 2024 5:51pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jul 26, 2024
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4400 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4400 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4400 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4400 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4400 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4400 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Uffizzi Preview deployment-54708 was deleted.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 26, 2024
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.14%. Comparing base (5e02eb4) to head (06bde23).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4400      +/-   ##
==========================================
+ Coverage   96.94%   97.14%   +0.19%     
==========================================
  Files        1180     1154      -26     
  Lines       39679    39808     +129     
==========================================
+ Hits        38467    38670     +203     
+ Misses       1212     1138      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 marked this pull request as ready for review July 31, 2024 11:11
@khvn26 khvn26 requested a review from a team as a code owner July 31, 2024 11:11
@khvn26 khvn26 requested review from zachaysan and removed request for a team July 31, 2024 11:11
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 31, 2024
@khvn26 khvn26 force-pushed the feat/org-level-integrations branch from d1780a2 to db5d694 Compare July 31, 2024 11:25
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 31, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jul 31, 2024
@khvn26 khvn26 marked this pull request as draft July 31, 2024 14:44
@khvn26 khvn26 removed the request for review from zachaysan July 31, 2024 14:45
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 21, 2024
@khvn26 khvn26 force-pushed the feat/org-level-integrations branch from 37bcf46 to a398235 Compare August 22, 2024 10:05
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 22, 2024
@khvn26 khvn26 requested review from a team and gagantrivedi and removed request for a team August 22, 2024 13:26
@khvn26 khvn26 force-pushed the feat/org-level-integrations branch from 182f2ab to 2f4749d Compare August 22, 2024 19:24
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 22, 2024
Copy link
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from two minor things:

  1. Missing coverage
  2. Test for delete

response = test_user_client.get(url)

# Then
assert response.status_code == status.HTTP_403_FORBIDDEN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a test for delete as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 28, 2024
@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Aug 28, 2024
@khvn26 khvn26 requested a review from gagantrivedi August 28, 2024 18:13
@khvn26 khvn26 changed the title feat: Organisation-level integrations feat: Backed support for Organisation-level integrations Aug 28, 2024
@khvn26 khvn26 changed the title feat: Backed support for Organisation-level integrations feat: Backend support for Organisation-level integrations Aug 28, 2024
@khvn26 khvn26 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 3e6b96f Aug 29, 2024
35 checks passed
@khvn26 khvn26 deleted the feat/org-level-integrations branch August 29, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants