feat: Add default rule for segments #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
|
@kyle-ssg I think E2E is legitimately broken here. |
|
Ah, yep I bet I adjusted tests when I originally removed this |
rolodato
approved these changes
Jun 4, 2024
4 tasks
|
@rolodato could you re-test this since it now also fixes the linked buggy segment rules |
rolodato
approved these changes
Jun 6, 2024
| @@ -319,49 +319,51 @@ const CreateSegment: FC<CreateSegmentType> = ({ | |||
| }, [operators, rules]) | |||
| //Find any non-deleted rules | |||
| const hasNoRules = !rules[0]?.rules?.find((v) => !v.delete) | |||
|
|
|||
| const rulesToShow = rules[0].rules.filter((v) => !v.delete) | |||
There was a problem hiding this comment.
Feel free to ignore this if I'm wrong - it just caught my attention that we're guarding against rules[0] being undefined or null on the line above, but not this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Adds placeholder rule for segments
How did you test this code?
Click create segment