Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder AND condition when creating segments #4001

Closed
rolodato opened this issue May 21, 2024 · 1 comment · Fixed by #4095
Closed

Add a placeholder AND condition when creating segments #4001

rolodato opened this issue May 21, 2024 · 1 comment · Fixed by #4095
Assignees
Labels
improvement Improvement to the existing platform

Comments

@rolodato
Copy link
Member

Is your feature request related to a problem? Please describe.

This is the UI to create a new segment:

image

To proceed, users must choose between "Add AND Condition" or "Add AND NOT Condition". I don't have data to back this up, but I would guess the vast majority of users will start by creating an AND condition. For unfamiliar users and demos, this masks what segments are for - if we showed the "trait" "condition" "value" boxes straight away, this becomes more self-evident by just looking at the UI. The word "trait" is mentioned twice in the text here, but it's not clear what it's referring to if you're not already familiar with segments.

The only situation that absolutely requires an AND NOT condition is if using an operator that does not have an opposite equivalent. As of today, these are only Modulo and In. Matches regex also does not have an opposite, but any regex is trivial to negate. All of these are fairly advanced use cases anyway.

Describe the solution you'd like.

Show the segment creation UI with one empty AND condition placeholder, something like this:

image

This makes it more obvious what segments are for and lets users define a simple segment without needing to choose between AND or AND NOT.

This also has the benefit of removing the second "NOTE" banner which just looks ugly.

Describe alternatives you've considered

We might want to make a larger redesign of the segment condition editor as described here #4000

However this issue is a quick win that can be implemented today with the current UI.

Additional context

No response

@kyle-ssg
Copy link
Member

kyle-ssg commented Jun 4, 2024

@rolodato Makes sense, I removed this initially due to the new AND NOT rule, but I was thinking the same about not being a more advanced case.

@kyle-ssg kyle-ssg assigned kyle-ssg and rolodato and unassigned kyle-ssg Jun 4, 2024
@kyle-ssg kyle-ssg linked a pull request Jun 4, 2024 that will close this issue
5 tasks
@rolodato rolodato added the improvement Improvement to the existing platform label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to the existing platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants