fix: Validate feature values before saving #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
|
Hmm... @kyle-ssg it looks like it's not clearing the state after failing validation once, see here: https://www.loom.com/share/37b89881d8f34b32a99d6e1101cb3bf0?sid=088017f1-ba32-40e3-9c70-ec6f67637e73 |
|
@kyle-ssg I've found one more way to get around the validation, which is by editing a segment override from the segment definition itself: Screen.Recording.2024-05-29.at.13.18.11.movEverything else I've tested works well 👍 |
|
@rolodato good spot, associated segment overrides will now include this too |
rolodato
approved these changes
May 30, 2024
4 tasks
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes the icon for when language validation fails
Saving features, segment overrides and creating change requests will now validate values in the same way.
How did you test this code?
Attempted to create an invalid change request, segment override and remote config