New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating segment overrides does not validate feature value language #4024

Closed

1 of 4 tasks

rolodato opened this issue May 24, 2024 · 1 comment

Closed

1 of 4 tasks

Creating segment overrides does not validate feature value language #4024

rolodato opened this issue May 24, 2024 · 1 comment

Labels

bug

Member

rolodato commented May 24, 2024

How are you running Flagsmith

Self Hosted with Docker
Self Hosted with Kubernetes
SaaS at flagsmith.com
Some other way (add details in description below)

Describe the bug

See steps below. This does not affect environment-level feature values or identity overrides.

Steps To Reproduce

Edit any feature
Create a segment override and select a language for the string value, like JSON
Input invalid JSON and save the segment override
The segment override is saved with invalid JSON

Expected behavior

Segment overrides should not allow saving feature values with invalid JSON/XML/TOML/YAML.

Screenshots

rolodato added the bug label

Member Author

rolodato commented May 31, 2024

Fixed by #4043, closing.

rolodato closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment