Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show 'Invite members' if email is not set up #4036

Closed
matthewelwell opened this issue May 28, 2024 · 1 comment · Fixed by #5022
Closed

Don't show 'Invite members' if email is not set up #4036

matthewelwell opened this issue May 28, 2024 · 1 comment · Fixed by #5022
Assignees

Comments

@matthewelwell
Copy link
Contributor

Currently the 'Users and permissions' screen in organisation settings will show the 'Invite members' button (which triggers an email invite) regardless of whether email configuration has been added to the API.

We have a couple of options to solve this:

  1. If the FE receives an error when sending an invite, then show a dialog recommending that they use invite links instead
  2. The API can add an attribute to e.g. the version endpoint which indicates whether email configuration has been added or not. If not, the FE can disable the button and show a tooltip.

The preference here is likely (2), but I did enjoy the experience from Metabase which is more along the lines of (1).

@kyle-ssg
Copy link
Member

kyle-ssg commented May 28, 2024

I think 1 only works if entering the email and submitting does something useful, in Metabase's case it creates the user and assigns a password I think?

If we just handled failed submissions then entering the email would have been pointless in the first place, I think 2 is more suitable unless we did something with the entered email e.g. prefil the login/signup form or attempt to create the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants