Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove feature modal #3608

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: remove feature modal #3608

merged 1 commit into from
Mar 13, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Mar 13, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR adjusted the remove feature modal to be able to appear above other modals (specifically the create feature modal). However further adjustments needed to be made to allow for the modal to close.

E2E was breaking on the PR but for some reason allowed me to merge.

How did you test this code?

  • E2E now passes
  • Removed a feature on preview URL

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 2:01pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 2:01pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 2:01pm

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Uffizzi Preview deployment-48310 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 9d737ad Mar 13, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the fix/remove-feature-modal branch March 13, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants