-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add state feature filter #3541
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3541 +/- ##
========================================
Coverage 95.86% 95.86%
========================================
Files 1099 1099
Lines 34282 34455 +173
========================================
+ Hits 32864 33032 +168
- Misses 1418 1423 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the whole this looks 👌 but I've added a few minor comments where I think some improvements can be made.
I think there's only one actual necessary change which is related to setting the type
in the query filter as well.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Fixes #3243
Introduce the ability to filter based off of the feature's value or enabled status, but only when connected to a given environment. Note that there is a limitation at present when filtering off of features with an integer value since I was not able to find a workable
icontains
that is handled by that workflow in Django.How did you test this code?
Manually tested a lot of combinations, kept two of them for the actual tests since they are lengthy tests.