-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add role api keys in UI #3042
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3042 +/- ##
==========================================
- Coverage 95.93% 95.92% -0.01%
==========================================
Files 1088 1088
Lines 33818 33825 +7
==========================================
+ Hits 32443 32447 +4
- Misses 1375 1378 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok, but as per previous comment, it doesn't appear to be working. Mostly leaving this review comment to remove this PR from my list because GH doesn't seem to have a function to do it another way.
@matthewelwell I found the issue, and now is solved, I had to split the backend: #3346 |
Hey @matthewelwell, I changed the title and added a field in the API keys table to see if it is an admin API key or not. I will create an issue for the API keys documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now, but one improvement that I'd like to see (which can maybe be done in a separate PR) is some kind of indication that a key is active / expired. I've added a has_expired
parameter to the API here I think we should just use that and display it in the table for now?
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
How did you test this code?