Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): hide API keys from integrations list #3019

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Fixes #3018.

Note: requires the addition of the attribute "hidden": true to each field that should be hidden in each integration. I have done this in staging already.

How did you test this code?

Ran the FE locally and verified that the relevant fields were hidden / not hidden.

@matthewelwell matthewelwell requested review from a team and novakzaballa and removed request for a team November 21, 2023 21:40
Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 9:47pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 9:47pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 9:47pm

Copy link
Contributor

github-actions bot commented Nov 21, 2023

Uffizzi Preview deployment-41246 was deleted.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewelwell matthewelwell added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit b02a524 Nov 21, 2023
@matthewelwell matthewelwell deleted the feat/hide-api-keys branch November 21, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show API keys in Integrations list
2 participants