Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show API keys in Integrations list #3018

Closed
matthewelwell opened this issue Nov 21, 2023 · 0 comments · Fixed by #3019
Closed

Don't show API keys in Integrations list #3018

matthewelwell opened this issue Nov 21, 2023 · 0 comments · Fixed by #3019
Assignees
@gnumoreno
Labels
front-end Issue related to the React Front End Dashboard good first issue Good for newcomers

Comments

@matthewelwell
Copy link
Contributor

matthewelwell commented Nov 21, 2023 •
edited
Loading

Currently in the list of integrations we show all the information about each configured integration, including the API key. We should blank out the API key, and only show it in the edit view if the user clicks on a 'show' icon in the edit field.

Current View:

image

Suggested Changes:

image Screenshot 2023-11-21 at 18 40 14
@matthewelwell matthewelwell added good first issue Good for newcomers front-end Issue related to the React Front End Dashboard labels Nov 21, 2023
@gnumoreno gnumoreno self-assigned this Nov 21, 2023
@matthewelwell matthewelwell mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnumoreno gnumoreno

Labels
front-end Issue related to the React Front End Dashboard good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ui): hide API keys from integrations list Flagsmith/flagsmith
2 participants
@gnumoreno @matthewelwell