Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include x-flagsmith-signature header when webhook is triggered by test webhook widget #2786

Closed
gagantrivedi opened this issue Sep 18, 2023 · 3 comments · Fixed by #3666
Closed

Include x-flagsmith-signature header when webhook is triggered by test webhook widget #2786

gagantrivedi opened this issue Sep 18, 2023 · 3 comments · Fixed by #3666
Assignees
@dabeeeenster @shubham-padia
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@gagantrivedi
Copy link
Member

Include x-flagsmith-signature header when webhook is triggered by test webhook widget

To Reproduce

Steps to reproduce the behavior:

  1. Click on Create webhook and url and secret
  2. Click on test webhook
  3. Observe: no x-flagsmith-signature header is sent

A clear and concise description of what you expected to happen.

It should include x-flagsmith-signature header
@gagantrivedi gagantrivedi added the bug Something isn't working label Sep 18, 2023
@matthewelwell matthewelwell added the good first issue Good for newcomers label Nov 15, 2023
@shubham-padia
Copy link
Contributor

I would like to work on this issue

@dabeeeenster
Copy link
Contributor

awesome - assigned!

shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Mar 25, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
26608c8 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Mar 25, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
a52cb1e 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
@shubham-padia shubham-padia mentioned this issue Mar 25, 2024
Merged
5 tasks
shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Mar 25, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
446e372 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
@shubham-padia
Copy link
Contributor

@dabeeeenster I have opened a PR at #3666, PTAL when possible

shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Mar 25, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
39cc696 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Apr 2, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
5c6bef7 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Apr 2, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
50c30ea 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Apr 3, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
f9d6237 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Apr 3, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
c731532 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
shubham-padia added a commit to shubham-padia/flagsmith that referenced this issue Apr 3, 2024
@shubham-padia
fix: Add Flagsmith signature header when testing webhook.
c2c7c73 
Fixes Flagsmith#2786.
We are trying to create the same signature as the webhook
in the python code. This commit assumes that the python code
will use the same approach to create signature for long term.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dabeeeenster dabeeeenster

@shubham-padia shubham-padia

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add Flagsmith signature header when testing webhook. shubham-padia/flagsmith
4 participants
@dabeeeenster @shubham-padia @matthewelwell @gagantrivedi