Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhooks): fix skipping webhooks calls on timeouts #2501

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 21, 2023

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #2500.

  • Handle all HTTP errors, including timeouts
  • Send the error name as part of failure email

How did you test this code?

Added a unit test.

- Handle all HTTP errors, including timeouts
- Send the error name as part of failure email
@khvn26 khvn26 requested review from a team and matthewelwell July 21, 2023 16:23
@vercel
Copy link

vercel bot commented Jul 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 4:25pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 4:25pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 21, 2023 4:25pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Uffizzi Preview deployment-31529 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (d150c7f) 95.42% compared to head (bbbe261) 95.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
+ Coverage   95.42%   95.43%   +0.01%     
==========================================
  Files         963      963              
  Lines       27044    27061      +17     
==========================================
+ Hits        25807    25827      +20     
+ Misses       1237     1234       -3     
Impacted Files Coverage Δ
api/webhooks/tests/test_webhooks.py 100.00% <100.00%> (ø)
api/webhooks/webhooks.py 95.12% <100.00%> (+3.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@khvn26 khvn26 merged commit 583e248 into main Jul 21, 2023
@khvn26 khvn26 deleted the fix/webhook-timeouts branch July 21, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook calls are skipped in case of timeouts
3 participants