Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webhook calls are skipped in case of timeouts #2500

Closed
3 of 4 tasks
khvn26 opened this issue Jul 21, 2023 · 1 comment · Fixed by #2501
Closed
3 of 4 tasks

Webhook calls are skipped in case of timeouts #2500

khvn26 opened this issue Jul 21, 2023 · 1 comment · Fixed by #2501
Assignees
@khvn26
Labels
bug Something isn't working

Comments

@khvn26
Copy link
Member

khvn26 commented Jul 21, 2023

Describe the bug

If an environment has more than one webhook configured, in case one of the webhooks raises a timeout, the subsequent ones do not get called.

To Reproduce

Steps to reproduce the behavior:

  1. Configure 2 webhooks for an environment. First webhook should respond longer than 2 seconds.
  2. Trigger them by editing a flag value.
  3. Observe only one of the webhooks get called.

Expected behavior

All webhooks get called regardless of the response timeouts.

How are you running Flagsmith?

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way
@khvn26 khvn26 added the bug Something isn't working label Jul 21, 2023
@khvn26 khvn26 self-assigned this Jul 21, 2023
@khvn26 khvn26 mentioned this issue Jul 21, 2023
Merged
4 tasks
@sentry-io
Copy link

sentry-io bot commented Jul 21, 2023

Sentry issue: FLAGSMITH-API-34X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khvn26 khvn26

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(webhooks): fix skipping webhooks calls on timeouts Flagsmith/flagsmith
1 participant
@khvn26