feat: Migrate to poetry

[tushar5526]

Closes #2150

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 6:45pm
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 6:45pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 3, 2023 6:45pm

[vercel]

@tushar5526 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

[tushar5526]

Do you also want Dockerfile.redhat-ubi to be migrated as well ?

[dabeeeenster]

Do you also want Dockerfile.redhat-ubi to be migrated as well ?

Yes please! Also the Dockerfile in the root of the repo which is our main file

[dabeeeenster]

Great thanks! cc @matthewelwell there are also a few ECS related Github actions that we need to update

[dabeeeenster]

Also the makefile

[github-actions]

Uffizzi Preview deployment-32543 was deleted.

[tushar5526]

Hey @dabeeeenster the PR is ready for review and I would need the following information as well.

[tool.poetry]
name = "y"
version = "0.1.0"
description = ""
authors = ["Your Name [email protected]"]
readme = "README.md"
License

[tushar5526]

Fixed the falling tests. It seems 2 GHAs need approvals before they can run.

[gagantrivedi]

Fixed the falling tests. It seems 2 GHAs need approvals before they can run.

Hi @tushar5526 those two action are deployment related - we can skip them for now

[tushar5526]

@khvn26 Thank you for the detailed feedback.

Few things to notice in recent commits.

• RUN apt-get update && apt-get install -y gcc build-essential libpq-dev musl-dev python3-dev services still seems to build and run fine without this.

• We are also copying bin folder from build-stage to copy executables now. Earlier venv used to contain all the site-packages and executables which were copied to application. https://github.com/Flagsmith/flagsmith/pull/2214/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R39

• https://github.com/Flagsmith/flagsmith/pull/2214/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L39, moved COPY further down in build process to cache apt-get update and installs

[tushar5526]

I have switched to ~ requirements. We can keep switching to caret requirements moving forward.

[khvn26]

This looks good to me. Great job, @tushar5526 🚀

[matthewelwell]

Reviewing the list here, it seems there are a few major version upgrades still (I'm making the assumption that pyproject.toml generated versions are File 1). Of those, I think google-auth is the only one that's concerning as I think we're requiring that directly?

[tushar5526]

Reviewing the list here, it seems there are a few major version upgrades still (I'm making the assumption that pyproject.toml generated versions are File 1). Of those, I think google-auth is the only one that's concerning as I think we're requiring that directly?

Yes your assumption is right.

google-api-python-client==1.12.5
    # via -r requirements.in
google-auth==1.23.0
    # via
    #   google-api-core
    #   google-api-python-client
    #   google-auth-httplib2

google-api-python-client is constrained using ~ and google-auth is not listed as a core dependency in requirements.in file, hence the version bump 🤔

Here is the dependency tree for google-api-python-client if it helps

[matthewelwell]

@tushar5526 can you rebase and let's get this merged 🙌

[tushar5526]

@tushar5526 can you rebase and let's get this merged 🙌

Squash the commits as well?

[matthewelwell]

Squash the commits as well?

Up to you, we will squash and merge the PR so it's not necessary to squash commits. You can just merge the main branch in rather than rebase if that's easier.

[tushar5526]

Squash the commits as well?

Up to you, we will squash and merge the PR so it's not necessary to squash commits. You can just merge the main branch in rather than rebase if that's easier.

Yes, you can squash them then! I have merged the main branch.