Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Poetry #2150

Closed
4 tasks
khvn26 opened this issue Apr 24, 2023 · 9 comments · Fixed by #2214
Closed
4 tasks

Migrate to Poetry #2150

khvn26 opened this issue Apr 24, 2023 · 9 comments · Fixed by #2214
Assignees
Labels
improvement Improvement to the existing platform

Comments

@khvn26
Copy link
Member

khvn26 commented Apr 24, 2023

Python packaging isn't solved yet but Poetry is the most popular closest-to-the-solution thing out there.

With Poetry, we'll get:

  • Dependency locks.
  • Automatic venvs.
  • Python version pinning.
  • Runtime and dev dependencies managed in pyproject.toml.
  • Neat build targets in a future Makefile.

Migration checklist

  • api project is Poetry-installable.
  • Build isn't broken for both Dockerfiles.
  • All api- and platform- workflows are not broken.
  • Update documentation
@khvn26 khvn26 assigned dabeeeenster and khvn26 and unassigned dabeeeenster Apr 24, 2023
@tushar5526
Copy link
Contributor

Hi folks, I am interested to solve this one. Should this be a one big PR or broken into multiple small PRs?

@dabeeeenster
Copy link
Contributor

I don't think there are TOO many things to change here? So I would go for 1 PR.

@dabeeeenster dabeeeenster added the improvement Improvement to the existing platform label Jun 6, 2023
@tushar5526
Copy link
Contributor

I think I forgot to add the documentation updates with the PR.

@matthewelwell
Copy link
Contributor

I think I forgot to add the documentation updates with the PR.

Ah yes, could you submit a separate PR with that?

@tushar5526
Copy link
Contributor

I can't seem to find any docs for it, where should I put it ?

I think basic instructions to setup the project, and running tests is enough

@dabeeeenster
Copy link
Contributor

@dabeeeenster
Copy link
Contributor

hey @tushar5526 - just checking to see if you are still planning on working on the docs? No problem if not, but we don't want to duplicate your work - thanks!

@tushar5526
Copy link
Contributor

I would love to do it, but I won't be able to do it till the weekend.

@dabeeeenster
Copy link
Contributor

OK sure no problem - thanks for the reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to the existing platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants