fix: Throw exception if Installation ID is not provided

Flagsmith · May 28, 2024 · 918207d · 918207d
1 parent b113d28
commit 918207d
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/api/integrations/github/github.py b/api/integrations/github/github.py
@@ -47,13 +47,12 @@
 
 def handle_installation_deleted(payload: dict[str, typing.Any]) -> None:
     installation_id = payload.get("installation", {}).get("id")
-    if installation_id:
-        try:
-            GithubConfiguration.objects.get(installation_id=installation_id).delete()
-        except GithubConfiguration.DoesNotExist:
-            logger.error(
-                f"Github Configuration with installation_id {installation_id} does not exist"
-            )
+    try:
+        GithubConfiguration.objects.get(installation_id=installation_id).delete()
+    except GithubConfiguration.DoesNotExist:
+        logger.error(
+            f"Github Configuration with installation_id {installation_id} does not exist"
+        )
 
 
 def tag_feature_per_github_event(