Remove get_related_feature_id logic and add a new endpoint to retri…

…eve an environment feature version without the path args

api/audit/serializers.py

@@ -3,7 +3,6 @@
 from drf_yasg.utils import swagger_serializer_method
 from rest_framework import serializers
 
-from audit.audit_helpers import get_related_feature_id
 from audit.models import AuditLog
 from environments.serializers import EnvironmentSerializerLight
 from projects.serializers import ProjectListSerializer
@@ -43,7 +42,6 @@ class AuditLogRetrieveSerializer(serializers.ModelSerializer):
     project = ProjectListSerializer()
     change_details = serializers.SerializerMethodField()
     change_type = serializers.SerializerMethodField()
-    related_feature_id = serializers.SerializerMethodField()
 
     class Meta:
         model = AuditLog
@@ -60,7 +58,6 @@ class Meta:
             "is_system_event",
             "change_details",
             "change_type",
-            "related_feature_id",
         )
 
     @swagger_serializer_method(
@@ -86,9 +83,6 @@ def get_change_type(self, instance: AuditLog) -> str:
             "~": "UPDATE",
         }.get(history_record.history_type)
 
-    def get_related_feature_id(self, instance: AuditLog) -> int | None:
-        return get_related_feature_id(instance)
-
 
 class AuditLogsQueryParamSerializer(serializers.Serializer):
     project = serializers.IntegerField(required=False)

api/features/versioning/permissions.py

@@ -35,6 +35,13 @@ def has_object_permission(
         )
 
 
+class EnvironmentFeatureVersionRetrievePermissions(BasePermission):
+    def has_object_permission(self, request, view, obj):
+        return request.user.has_environment_permission(
+            VIEW_ENVIRONMENT, obj.environment
+        )
+
+
 class EnvironmentFeatureVersionFeatureStatePermissions(BasePermission):
     def has_permission(self, request: Request, view: GenericViewSet) -> bool:
         environment_pk = view.kwargs["environment_pk"]

api/features/versioning/urls.py

@@ -4,6 +4,7 @@
 
 from features.versioning.views import (
     EnvironmentFeatureVersionFeatureStatesViewSet,
+    EnvironmentFeatureVersionRetrieveAPIView,
     EnvironmentFeatureVersionViewSet,
 )
 
@@ -34,4 +35,9 @@
         "environments/<int:environment_pk>/features/<int:feature_pk>/",
         include(ef_version_fs_router.urls),
     ),
+    path(
+        "environment-feature-versions/<str:pk>/",
+        EnvironmentFeatureVersionRetrieveAPIView.as_view(),
+        name="get-efv-by-id",
+    ),
 ]

api/features/versioning/views.py

@@ -4,6 +4,7 @@
 from django.utils.decorators import method_decorator
 from drf_yasg.utils import swagger_auto_schema
 from rest_framework.decorators import action
+from rest_framework.generics import RetrieveAPIView
 from rest_framework.mixins import (
     CreateModelMixin,
     DestroyModelMixin,
@@ -26,6 +27,7 @@
 from features.versioning.permissions import (
     EnvironmentFeatureVersionFeatureStatePermissions,
     EnvironmentFeatureVersionPermissions,
+    EnvironmentFeatureVersionRetrievePermissions,
 )
 from features.versioning.serializers import (
     EnvironmentFeatureVersionFeatureStateSerializer,
@@ -135,6 +137,17 @@ def publish(self, request: Request, **kwargs) -> Response:
         return Response(serializer.data)
 
 
+class EnvironmentFeatureVersionRetrieveAPIView(RetrieveAPIView):
+    permission_classes = [
+        IsAuthenticated,
+        EnvironmentFeatureVersionRetrievePermissions,
+    ]  # TODO
+    serializer_class = EnvironmentFeatureVersionRetrieveSerializer
+
+    def get_queryset(self):
+        return EnvironmentFeatureVersion.objects.all()
+
+
 class EnvironmentFeatureVersionFeatureStatesViewSet(
     GenericViewSet,
     ListModelMixin,

api/tests/unit/audit/test_unit_audit_views.py

@@ -182,7 +182,6 @@ def test_retrieve_environment_feature_version_published_audit_log_record_include
     response_json = response.json()
     assert response_json["related_object_uuid"] == str(new_version.uuid)
     assert response_json["related_object_type"] == RelatedObjectType.EF_VERSION.name
-    assert response_json["related_feature_id"] == new_version.feature_id
     assert (
         response_json["log"]
         == ENVIRONMENT_FEATURE_VERSION_PUBLISHED_MESSAGE % feature.name

api/tests/unit/features/versioning/test_unit_versioning_views.py

@@ -758,3 +758,42 @@ def test_disable_v2_versioning_returns_bad_request_if_not_using_v2_versioning(
 
     # Then
     assert response.status_code == status.HTTP_400_BAD_REQUEST
+
+
+def test_retrieve_environment_feature_version_without_path_args(
+    feature: Feature,
+    environment_v2_versioning: Environment,
+    staff_client: APIClient,
+    with_environment_permissions: WithEnvironmentPermissionsCallable,
+) -> None:
+    # Given
+    efv = EnvironmentFeatureVersion.objects.first()
+
+    url = reverse("api-v1:versioning:get-efv-by-id", args=[efv.uuid])
+    with_environment_permissions([VIEW_ENVIRONMENT], efv.environment_id)
+
+    # When
+    response = staff_client.get(url)
+
+    # Then
+    assert response.status_code == status.HTTP_200_OK
+
+    response_json = response.json()
+    assert response_json["uuid"] == str(efv.uuid)
+
+
+def test_retrieve_environment_feature_version_without_path_args_permission_denied(
+    feature: Feature,
+    environment_v2_versioning: Environment,
+    staff_client: APIClient,
+) -> None:
+    # Given
+    efv = EnvironmentFeatureVersion.objects.first()
+
+    url = reverse("api-v1:versioning:get-efv-by-id", args=[str(efv.uuid)])
+
+    # When
+    response = staff_client.get(url)
+
+    # Then
+    assert response.status_code == status.HTTP_403_FORBIDDEN