Skip to content

Commit

Permalink
fix: don't create audit log for FeatureStateValue when not published (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewelwell authored May 31, 2024
1 parent e4cd25a commit 8b73b5c
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
3 changes: 3 additions & 0 deletions api/features/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,9 @@ def copy_from(self, source_feature_state_value: "FeatureStateValue"):
self.string_value = source_feature_state_value.string_value
self.save()

def get_skip_create_audit_log(self) -> bool:
return self.feature_state.get_skip_create_audit_log()

def get_update_log_message(self, history_instance) -> typing.Optional[str]:
fs = self.feature_state

Expand Down
19 changes: 18 additions & 1 deletion api/tests/unit/features/test_unit_features_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ def test_feature_state_get_skip_create_audit_log_if_uncommitted_change_request(


def test_feature_state_get_skip_create_audit_log_if_environment_feature_version(
environment_v2_versioning, feature
environment_v2_versioning: Environment, feature: Feature
):
# Given
environment_feature_version = EnvironmentFeatureVersion.objects.get(
Expand All @@ -676,6 +676,23 @@ def test_feature_state_get_skip_create_audit_log_if_environment_feature_version(
assert feature_state.get_skip_create_audit_log() is True


def test_feature_state_value_get_skip_create_audit_log_if_environment_feature_version(
environment_v2_versioning: Environment, feature: Feature
):
# Given
environment_feature_version = EnvironmentFeatureVersion.objects.get(
environment=environment_v2_versioning, feature=feature
)
feature_state = FeatureState.objects.get(
environment=environment_v2_versioning,
feature=feature,
environment_feature_version=environment_feature_version,
)

# Then
assert feature_state.feature_state_value.get_skip_create_audit_log() is True


@pytest.mark.parametrize(
"feature_segment_id, identity_id, expected_function_name",
(
Expand Down

0 comments on commit 8b73b5c

Please sign in to comment.