Skip to content

Commit

Permalink
Remove legacy healthcheck from Compose, use new check in Dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
rolodato committed Feb 25, 2025
1 parent 2c37c6f commit 236df86
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
3 changes: 3 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ ENTRYPOINT ["/app/scripts/run-docker.sh"]

CMD ["migrate-and-serve"]

HEALTHCHECK --interval=2s --timeout=2s --retries=3 --start-period=20s \
CMD curl -f http://localhost:8000/health/liveness || exit 1

# * api-runtime-private [api-runtime]
FROM api-runtime AS api-runtime-private

Expand Down
6 changes: 0 additions & 6 deletions docker-compose.pgpool.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ services:
TASK_RUN_METHOD: TASK_PROCESSOR # other options are: SYNCHRONOUSLY, SEPARATE_THREAD (default)
ports:
- 8000:8000
healthcheck:
test: ['CMD-SHELL', 'python /app/scripts/healthcheck.py']
interval: 2s
timeout: 2s
retries: 20
start_period: 20s
depends_on:
pgpool:
condition: service_healthy
Expand Down
6 changes: 0 additions & 6 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,6 @@ services:
# EMAIL_USE_TLS: 'true' # optional
ports:
- 8000:8000
healthcheck:
test: ['CMD-SHELL', 'python /app/scripts/healthcheck.py']
interval: 2s
timeout: 2s
retries: 20
start_period: 20s
depends_on:
postgres:
condition: service_healthy
Expand Down

0 comments on commit 236df86

Please sign in to comment.