Skip to content

Commit

Permalink
fix(saas): add correct GITHUB env vars to all locations (#3840)
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewelwell authored Apr 25, 2024
1 parent 82b43a9 commit 12242c4
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,10 @@
{
"name": "HUBSPOT_IGNORE_DOMAINS",
"value": "flagsmith.com,solidstategroup.com,restmail.net,bullettrain.io,flagsmithe2etestdomain.io"
},
{
"name": "GITHUB_APP_ID",
"value": "811209"
}
],
"secrets": [
Expand Down Expand Up @@ -206,6 +210,10 @@
{
"name": "HUBSPOT_ACCESS_TOKEN",
"valueFrom": "arn:aws:secretsmanager:eu-west-2:084060095745:secret:ECS-API-LxUiIQ:HUBSPOT_ACCESS_TOKEN::"
},
{
"name": "GITHUB_PEM",
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:ECS-API-LxUiIQ:GITHUB_PEM::"
}
],
"logConfiguration": {
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/aws/production/ecs-task-definition-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@
},
{
"name": "GITHUB_PEM",
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:ECS-API-heAdoB:GITHUB_PEM::"
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:ECS-API-LxUiIQ:GITHUB_PEM::"
}
],
"logConfiguration": {
Expand Down
8 changes: 8 additions & 0 deletions infrastructure/aws/staging/ecs-task-definition-web.json
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@
{
"name": "USER_THROTTLE_CACHE_OPTIONS",
"value": "CLIENT_CLASS=core.redis_cluster.SafeRedisClusterClient"
},
{
"name": "GITHUB_APP_ID",
"value": "811209"
}
],
"secrets": [
Expand Down Expand Up @@ -236,6 +240,10 @@
{
"name": "SSE_AUTHENTICATION_TOKEN",
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:ECS-API-heAdoB:SSE_AUTHENTICATION_TOKEN::"
},
{
"name": "GITHUB_PEM",
"valueFrom": "arn:aws:secretsmanager:eu-west-2:302456015006:secret:ECS-API-heAdoB:GITHUB_PEM::"
}
],
"logConfiguration": {
Expand Down

0 comments on commit 12242c4

Please sign in to comment.