fix: make dependencies and other build arguments static #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for bringing up the issue. I don't think the dependencies should be repeated in two places, though. I think instead the dependencies can be listed in https://peps.python.org/pep-0631/#specification The ideal solution would probably be for everything in |
ohjunseung
changed the title
|
I'm not that familiar with pip build system. From your suggestion, this fc3aadf might be good for now. |
|
Thanks for your help on the issue, I hope it's fine with you if I add to this PR some additional static attributes |
DenverCoder1
approved these changes
Dec 19, 2022
DenverCoder1
changed the title
|
Just tested with 1.0.4 and it looks good to me 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to install version 1.0.3 with pip and it doesn't install the dependencies. Figured out that requirements.txt is not included in the source distribution, hence giving the install_requires an empty array. I assume this doesn't happen on 1.0.1 because it has a wheel file.
So, I thought that making the dependencies explicit is better.
References:
same issue with wheel