Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add religious symbols #89

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Conversation

lord-ne
Copy link
Contributor

@lord-ne lord-ne commented Jun 20, 2023

Add three religious symbols: \latinCross ✝︎, \starAndCrescent ☪︎, and \starOfDavid ✡︎. I think it's a very bad look for the only religious symbols in this entire dictionary to be the swastikas from #87, regardless of how innocently it is intended.

Potentially some other religious symbols could be added (this Wikipedia list is a good place to look). But ultimately I'm not familiar enough with enough religions to say which symbols are important, so I just left it at these three for this PR.

lord-ne added 2 commits June 20, 2023 13:50
Add the unicode VS15 character to specify that these symbols should be displayed in text form and not emoji form
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1
Copy link
Owner

On my computer it seems that even with the Variation Selector 15 (U+FE0E) it doesn't display as text but it does seem like that's a good idea to have that for systems that do honor that.

@DenverCoder1 DenverCoder1 changed the title Add religious symbols feat: Add religious symbols Jun 20, 2023
@DenverCoder1 DenverCoder1 merged commit 02c1c3c into DenverCoder1:master Jun 20, 2023
@PointedEars
Copy link

PointedEars commented Jun 22, 2023

This dictionary should be for science writing only, and should not promote any religion, or be cluttered with seldom-used or questionable symbols just because some LaTeX library supports them. Adding the astrology symbols and swastikas already was questionable (the former can also be used for astronomy rather than the pseudoscience of astrology, so that was barely acceptable; and I am aware that the latter are originally and still a symbol of luck rather than the perverted meaning); adding even more religious symbols now would be the straw that breaks the camel’s back for me, and I would not pull or support upstream anymore (JFYI).

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Jun 22, 2023

This dictionary should be for science writing only, and should not promote any religion, or be cluttered with seldom-used or questionable symbols just because some LaTeX library supports them. Adding the astrology symbols and swastikas already was questionable (the former can also be used for astronomy rather than the pseudoscience of astrology, so that was barely acceptable; and I am aware that the latter are originally and still a symbol of luck rather than the perverted meaning); adding even more religious symbols now would be the straw that breaks the camel’s back for me, and I would not pull or support upstream anymore (JFYI).

Ultimately, it's your choice to use the project how you'd like. If you don't want to use these shortcuts, you don't have to. The extra few bytes it takes to store them is pretty negligible, so I don't really see any harm in allowing the community to add things they think some others would find useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants