Personas memories fix #1917
Open
Personas memories fix #1917
+24
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mdmohsin7
commented
Feb 27, 2025
•
mdmohsin7
commented
- 30s timeout for X api calls
- add try catch for sync_update_persona_prompt
- update the persona prompts async in a separate thread without disturbing the process_memory
|
1/ from my experience, this code block is the cause of websocket connection drop (/listen API). do you experience the same ? https://github.com/BasedHardware/omi/pull/1917/files#diff-e518096e8d0948a411d3035bacafc371d1a8600659b7b7f6ea667f73b2231dc4L195-R203 |
|
1/ I did not had issues when I was testing locally (with 30s timeout). I'll test it a bit more and maybe will move it to make it independent so no other function should be dependent on it |
|
1/ please do a small research. how does the thread impact to the python application ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.