Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proactive Notification Docs #1408 #1880

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

XxAlonexX
Copy link

Description

This PR adds comprehensive documentation for the proactive notifications system, addressing issue #1408. The documentation provides clear guidelines on how proactive notifications work and how they can be implemented in the Omi app.

Changes Made

  • Added new documentation file app/docs/proactive_notifications.md
  • Documented the following aspects of proactive notifications:
    • System overview and architecture
    • Setup and initialization process
    • Token management
    • Types of notifications supported
    • API endpoints for sending notifications
    • Notification handling in different app states
    • Best practices and troubleshooting guides

Testing Done

  • Verified all documentation links are working
  • Confirmed code examples are accurate and up-to-date
  • Validated API endpoint documentation

Related Issues

Closes #1408

Checklist

  • Documentation is clear and comprehensive
  • Code examples are properly formatted
  • All implementation details are accurately described
  • Best practices section is included
  • Troubleshooting guide is provided

Additional Notes

The documentation aims to help developers understand and implement proactive notifications effectively in their applications. It covers both client-side and server-side aspects of the notification system.

@beastoin
Copy link
Collaborator

@mdmohsin7 man, feel free to merge if you see it good 💪

@XxAlonexX
Copy link
Author

Thanks for the support, Feel free to ask for any changes if required :)

Copy link
Collaborator

@mdmohsin7 mdmohsin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @XxAlonexX, this documentation is not related to proactive notifications at all. Proactive notifications are a part of the backend which allow apps within omi to send notifications to omi users, and it has various scopes defining what all information can be used to draft the content of those notifications.

def get_notification_scopes():

def _process_proactive_notification(uid: str, token: str, plugin: App, data):

You can check the above references for an idea about proactive notifications

@XxAlonexX
Copy link
Author

Apologise for that sir, I'll make sure to make it up to your expectations

@beastoin beastoin marked this pull request as draft March 3, 2025 13:58
@beastoin
Copy link
Collaborator

beastoin commented Mar 3, 2025

48h no updates

/ draft

feel free to mark as Ready to review when you're ready.

@XxAlonexX
Copy link
Author

Sorry sir my exams are going on will be end tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proactive Notification Docs
3 participants