-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Date-based filtering for memories #1760
base: main
Are you sure you want to change the base?
Conversation
Update: Added filtering functionality |
Hi @aazam-gh, consider using the Cupertino date picker or a better alternative, as the Material one doesn’t look very good. |
@mdmohsin7 do you want me to add cuperino for iOS and keep the material one for android. |
screen-20250210-082702.mp4Made the UI cleaner for Android and also added cupertino for iOS |
1/ the filtering logic should happened on the back-end side, not local(in the app) |
The search filtering happens in
Single date, only that particular day's logs as described by the issue.
That filter button is for toggling discarded conversations. This allows them to filter their conversations by date. The calendar app defaults to show the current date to avoid confusion |
1/ implement it on back-end side please. man, you cannot tell the user that they don't have any convo one year ago just because the app(local) don't have it. |
Implemented filtering on the back-end |
oh sorry, missing this one / man, please turn the PR to Ready for review when everything is okay from your side @aazam-gh / btw 1/ could you use the current api route for the memories search instead of creating a new one and, clean your code please. e.g. adding new typesense here is nonsense 🫣 https://github.com/BasedHardware/omi/pull/1760/files#diff-d70139c124943f6f95145ac1930faf11d7e52612de3434c5aaa2ecf9b4a5e310R8-R17 |
This PR is to resolve #1735
I have added the UI so far.
I will now work on the backend part.
Here is a recording to demonstrate the progress so far.
screen-20250206-174212.mp4
Suggestions are welcome.