Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Date-based filtering for memories #1760

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

aazam-gh
Copy link

@aazam-gh aazam-gh commented Feb 6, 2025

This PR is to resolve #1735

I have added the UI so far.
I will now work on the backend part.
Here is a recording to demonstrate the progress so far.

screen-20250206-174212.mp4

Suggestions are welcome.

@aazam-gh
Copy link
Author

aazam-gh commented Feb 7, 2025

Update: Added filtering functionality

@mdmohsin7
Copy link
Collaborator

Hi @aazam-gh, consider using the Cupertino date picker or a better alternative, as the Material one doesn’t look very good.

@aazam-gh
Copy link
Author

aazam-gh commented Feb 9, 2025

@mdmohsin7 do you want me to add cuperino for iOS and keep the material one for android.
Cuperino date picker doesn't function smoothly on android

@aazam-gh
Copy link
Author

screen-20250210-082702.mp4

Made the UI cleaner for Android and also added cupertino for iOS

@beastoin
Copy link
Collaborator

1/ the filtering logic should happened on the back-end side, not local(in the app)
2/ is it the date range filter or just a single date ?
2/ we already have the filter icon. do you think adding a new calendar button for date filtering is a good idea? please make sure the new button does not confuse the user.

@aazam-gh

@beastoin beastoin marked this pull request as draft February 10, 2025 03:26
@aazam-gh
Copy link
Author

1/ the filtering logic should happened on the back-end side, not local(in the app)

The search filtering happens in conversations_provider.dart, I implemented the date filtering similarly in it as well.

2/ is it the date range filter or just a single date ?

Single date, only that particular day's logs as described by the issue.

3/ we already have the filter icon. do you think adding a new calendar button for date filtering is a good idea? please make sure the new button does not confuse the user.

That filter button is for toggling discarded conversations. This allows them to filter their conversations by date. The calendar app defaults to show the current date to avoid confusion

@beastoin

@beastoin
Copy link
Collaborator

1/ implement it on back-end side please. man, you cannot tell the user that they don't have any convo one year ago just because the app(local) don't have it.

@aazam-gh

@aazam-gh
Copy link
Author

Implemented filtering on the back-end

@beastoin
Copy link
Collaborator

beastoin commented Mar 3, 2025

oh sorry, missing this one / man, please turn the PR to Ready for review when everything is okay from your side @aazam-gh / btw

1/ could you use the current api route for the memories search instead of creating a new one and, clean your code please. e.g. adding new typesense here is nonsense 🫣 https://github.com/BasedHardware/omi/pull/1760/files#diff-d70139c124943f6f95145ac1930faf11d7e52612de3434c5aaa2ecf9b4a5e310R8-R17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date-Based Filtering for Memories ($500)
3 participants