C++ linter #163
Merged
C++ linter #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow these are a lot of changes, I hope it doesn't break any of the other PR, specially the one @shelhamer is doing in |
|
@sguada it's ok. We're going to merge the re-arrangement first then check this out. Having a clean cup of Caffe with these changes will be nice. Thanks @jeffdonahue. |
This was referenced Feb 26, 2014
(also change EXPECT_LT and EXPECT_GT pair to EXPECT_NEAR)
|
this is good to go (barring any further need to rebase) |
|
I vote we merge this now, then do another lint pass once #165 is in. I don't want this to be relegated to @jeffdonahue ok with you? |
|
Yup, sounds good to me |
|
@jeffdonahue great job It works great, I already found some "errors" in my code. |
shelhamer
added a commit
that referenced
this pull request
Feb 26, 2014
Lint C++ (suffer for fashion)
shelhamer
added a commit
that referenced
this pull request
Feb 26, 2014
Lint C++ (suffer for fashion)
Merged
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Lint C++ (suffer for fashion)
lukeyeager
pushed a commit
to lukeyeager/caffe
that referenced
this pull request
Jun 8, 2016
Moved file accidentally - moving it back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Google's C++ linter (scripts/cpp_lint.py) with "lint" target in Makefile (run "make lint" to run the linter on all C source/header files) and fix all of its errors for the current codebase. The linter statically checks C++ code against some of the C++ style conventions Caffe follows, heavily inspired by Google's C++ style guide.
If this PR is accepted, all future Caffe contributions should be required to run "make lint" with an output of "Total errors found: 0" before merging (returns status code 0 in this case). In some cases this may involve explicit suppression of certain false positive linter errors (or when there's just a good enough reason to break convention) using NOLINT and NOLINT_NEXTLINE (the latter of which I added to the cpp_lint.py script due to the same line NOLINT almost always making the line run over 80 characters).