[FEAT] Add "task" to the scoring memory entry #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) and added column in ScoreEntries
nina-msft
reviewed
Aug 26, 2024
nina-msft
reviewed
Aug 26, 2024
rdheekonda
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added task as arg for
Scoreinitialization (provided throughscore_asyncfunctions) and added column inScoreEntriesdb so that memory keeps track of task.I re-ran 1_memory notebook to ensure the column exists in
ScoreEntriesschema and re-ran all score unit tests (after adjusting a couple of the tests intest_self_ask_scaleto test task initialization)