-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sound and browser notifications for agent state changes #6530
Conversation
- Reverted vite.config.ts to main branch version - Reverted package.json and package-lock.json to main branch versions - Reverted Dockerfile to main branch version to maintain consistent Node.js version
- Added @types/react-router-dom package - Created custom type declaration for use-sound - Fixed linting issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very satisfying, but maybe we don't want to play the audio if the user is already focus on the tab?
hmm good point, although I think a lot of time, I put openhands in a separate screen with tab open, while working on the other screen. We'd actually want openhands to remind us in this case, right? |
I believe that you'd be "focusing" on a screen or tab if you click it. I haven't tried but this should mean that even if you have OpenHands on another screen, the tab will be considered "unfocused" if you're doing stuff on the other screen. You've provided the option to disable the audio too so IDM the current implementation either way |
@amanape Yeah.. I think another potential use case would be, I focus on the tab but I'm away in the kitchen cooking stuff 🤣.. In this usecase (that actually happens a lot to me) sound notification while in-focus could still be useful. But anyway, since we allow the user to toggle off this notification - it should be fine? if ppl are annoyed, they can simply turn this off. |
Then in that case maybe we can default to false |
done @amanape |
…l-Hands-AI#6530) Co-authored-by: openhands <[email protected]> Co-authored-by: amanape <[email protected]>
…l-Hands-AI#6530) Co-authored-by: openhands <[email protected]> Co-authored-by: amanape <[email protected]>
Add notification features to improve user experience when the agent needs attention:
Sound button:
Browser tab notification:
The notifications trigger when agent state changes to:
To run this PR locally, use the following command: