Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow http session reuse #6478

Merged
merged 1 commit into from
Jan 27, 2025
Merged

allow http session reuse #6478

merged 1 commit into from
Jan 27, 2025

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Jan 27, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    Fix for continuing sessions, which would originally result in a session_was_closed error

Give a summary of what the PR does, explaining any non-trivial design decisions

We should fix the underlying issue here, but this is a quick fix to make the app more usable.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:88a4d89-nikolaik   --name openhands-app-88a4d89   docker.all-hands.dev/all-hands-ai/openhands:88a4d89

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense

Copy link
Collaborator

@tofarr tofarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰 - But we will need to check periodically for open file descriptors

@rbren rbren merged commit 9611093 into main Jan 27, 2025
15 checks passed
@rbren rbren deleted the rb/reuse-sessions branch January 27, 2025 17:29
zchn pushed a commit to zchn/OpenHands that referenced this pull request Feb 4, 2025
idagelic pushed a commit to idagelic/OpenHands that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants