fix session leak #5656
Merged
fix session leak #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
commented
Dec 17, 2024
Comment on lines
+154
to
+165
| seconds_waited = 0 | ||
| while self._initializing: | ||
| logger.debug( | ||
| f'Waiting for initialization to finish before closing session {self.sid}' | ||
| ) | ||
| await asyncio.sleep(WAIT_TIME_BEFORE_CLOSE_INTERVAL) | ||
| seconds_waited += WAIT_TIME_BEFORE_CLOSE_INTERVAL | ||
| if seconds_waited > WAIT_TIME_BEFORE_CLOSE: | ||
| logger.error( | ||
| f'Waited too long for initialization to finish before closing session {self.sid}' | ||
| ) | ||
| break |
There was a problem hiding this comment.
This is the main fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
CHANGELOG: Fixed an issue where sessions sometimes don't close properly, causing memory and FD leaks
Give a summary of what the PR does, explaining any non-trivial design decisions
Make sure the session finishes initializing before closing it
Link of any specific issues this addresses
To run this PR locally, use the following command: