Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆙 Update for Node 16 support #178

Merged
merged 10 commits into from
Oct 1, 2024
Merged

🆙 Update for Node 16 support #178

merged 10 commits into from
Oct 1, 2024

Conversation

stoe
Copy link
Collaborator

@stoe stoe commented Aug 22, 2023

This pull request includes several updates to the codebase, focusing on modernizing dependencies, improving configurations, and refactoring code for better maintainability and readability. The most important changes include updates to ESLint and Prettier configurations, workflow adjustments, package updates, and refactoring of the codebase to use ES modules.

Configuration and Dependency Updates:

  • .eslintrc.json: Updated ecmaVersion to 2020 and sourceType to module. Adjusted ESLint rules for camelcase and added no-console rule. [1] [2]
  • .github/workflows/codeql.yml: Added environment variables and updated actions to specific commit hashes.
  • .github/workflows/test.yml: Updated Node.js version matrix to use 20.x.
  • action.yml: Updated Node.js version to 20 for the action runtime.
  • package.json: Added type: "module", updated dependencies and devDependencies, and modified scripts for better compatibility and performance. [1] [2]

Code Migration to ES Modules:

Testing and Linting:

Other Changes:

  • .prettierrc.cjs: Added ESLint directive and required Prettier configuration from eslint-plugin-github.
  • Removed prettier.config.js as it is now included in .prettierrc.cjs.

@stoe stoe requested a review from a team as a code owner August 22, 2023 08:00
@stoe stoe self-assigned this Aug 22, 2023
@stoe stoe requested a review from snsinahub August 22, 2023 08:00
@stoe stoe enabled auto-merge (squash) August 22, 2023 08:12
@stoe
Copy link
Collaborator Author

stoe commented Aug 22, 2023

Next step after merge: Create new release!

Copy link

@gclhub gclhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stoe I saw that you already have a PR to a newer nodeJS version in this repo, so I added a couple of suggestions to upgrade to node v20 in response to the prompt from @stebje to upgrade the ActionsDesk repositories.

@stoe stoe requested a review from gclhub September 29, 2024 09:51
Copy link

@gclhub gclhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@stoe stoe merged commit 5039223 into main Oct 1, 2024
3 of 4 checks passed
@stoe stoe deleted the stoe/node-16-ready branch October 1, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants