-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🆙 Update for Node 16 support #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exclude `dist/*`
Next step after merge: Create new release! |
gclhub
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stoe
commented
Sep 29, 2024
Co-authored-by: Greg Larkin <[email protected]>
gclhub
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the codebase, focusing on modernizing dependencies, improving configurations, and refactoring code for better maintainability and readability. The most important changes include updates to ESLint and Prettier configurations, workflow adjustments, package updates, and refactoring of the codebase to use ES modules.
Configuration and Dependency Updates:
.eslintrc.json
: UpdatedecmaVersion
to 2020 andsourceType
tomodule
. Adjusted ESLint rules forcamelcase
and addedno-console
rule. [1] [2].github/workflows/codeql.yml
: Added environment variables and updated actions to specific commit hashes..github/workflows/test.yml
: Updated Node.js version matrix to use20.x
.action.yml
: Updated Node.js version to20
for the action runtime.package.json
: Addedtype: "module"
, updated dependencies and devDependencies, and modified scripts for better compatibility and performance. [1] [2]Code Migration to ES Modules:
src/index.js
: Refactored to use ES module syntax and updated imports accordingly. [1] [2]src/report.js
: Converted to ES module and updated import statements. [1] [2] [3]Testing and Linting:
tests/index.t.js
: Removed the old CommonJS-based test file.tests/report.t.js
: Updated to use ES module syntax and adjusted mocks accordingly. [1] [2]Other Changes:
.prettierrc.cjs
: Added ESLint directive and required Prettier configuration fromeslint-plugin-github
.prettier.config.js
as it is now included in.prettierrc.cjs
.