Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackwell compatibility (Windows only) #16817

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Blackwell compatibility (Windows only) #16817

merged 2 commits into from
Jan 30, 2025

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jan 30, 2025

Description

Switch to isntall early access pytorch wheels if the user is has a Blackwell GPU

wheels are upload to huggingface with permission from Nvidia
https://huggingface.co/w-e-w/torch-2.6.0-cu128.nv

from my testing all seems to work fine
apart from the optional --xformers

the current xformers pre-built only suppors pytorch 2.5.1

test was done with python 3.10 and 3.11 on 3090 and 1650 cards


if someone wish to test compatibility on non-blackwell cards
override the condiction at

if all([
os.environ.get('TORCH_INDEX_URL') is None,
sys.version_info.major == 3,
sys.version_info.minor in (10, 11, 12),
platform.system() == "Windows",
get_cuda_comp_cap() >= 10, # Blackwell
]):


note blackwell support should be considered experimental / theoretical
feedback with actual hardware test is more the welcome

Checklist:

@catboxanon
Copy link
Collaborator

I have two GPUs installed, so the output returned by nvidia-smi can't be parsed.

>>> float(subprocess.check_output(['nvidia-smi', '--query-gpu=compute_cap', '--format=noheader,csv'], text=True))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: could not convert string to float: '8.6\n7.5\n'

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jan 30, 2025

thanks I see what's happening
I didn't know that could happen
it turns out I actually did know that this could happen I just forgot, I've encountered this exact issue in the past
https://github.com/w-e-w/stable-diffusion-webui-GPU-temperature-protection/blob/f388d7081945576ca2361c365d16f5edb3250412/temperature_sensor_modules/nvidia_smi.py#L8

@w-e-w
Copy link
Collaborator Author

w-e-w commented Jan 30, 2025

@catboxanon shoud be fixed

@catboxanon catboxanon merged commit 57e15ec into dev Jan 30, 2025
6 checks passed
@catboxanon catboxanon deleted the Blackwell branch January 30, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants