-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch not reported correctly on coveralls.io #1697
Comments
It looks fine on your end so it's probably me. I'll check the coveralls API tomorrow and make sure I'm not missing out on any of the optional fields I can set in the request! |
Interestingly, I just created a new branch and committed it. That seems to have been picked up as intended. Making a second commit on this new branch also works. Perhaps, it is important to point out, that the "troubled" branch is called "dev/v0.10". Maybe that's part of the issue. Hope this helps somewhat :) |
Yeah I've recreated the same behaviour, and managed to find an open source project which has branches with |
Here's my coveralls project, if that helps: https://coveralls.io/github/polyphony-chat/polyproto-rs Thank you for looking into it so timely! |
Got a branch where I'm trying out some stuff #1699 |
https://coveralls.io/github/xd009642/rust-sandbox?branch=feat/do-slashs-pls well I have a job with slashes in the name! One thing to note, if it's in a PR GHA often runs against the master state of the CI config (I think partially as a security measure) and for these instances the branch name is incorrectly "master". That's what libgit2 reports so likely due to some nonsense in how github actions work... But when it's set to branches: "**" on push I got the slash properly This has lead to some improved error reporting and logging for coveralls and I now set a bit more of the data I can set on a request to let it know about the repo so maybe I did something or maybe it's github shenanigans. But as I see the correct branch name in your actions tab on the branch for past workflows it should hopefully work for you with my changes. Just going to tidy up and publish! |
Okay the publish machine is running so it'll be on crates.io whenever the CI finishes (normally like 15 minutes at most). If you can let me know if it improves anything your end 🙏 |
Thank you for your hard work! I have tested your changes by running with version |
This just in: CI gives an indicator for why things might not work. Also, the CI pipeline fails now :P |
aha me not ignoring coveralls errors has had unintended debugging benefits... Okay this might be based on how GHA does things... Maybe I need to use one of their env vars to get the branch name instead of libgit. It looks like this is a bit of an annoying github issue https://github.com/orgs/community/discussions/5251 I'm definitely not happy about how sometimes it reports the branch name correctly and sometimes it seems I just get rubbish 💀 |
Side note I'm travelling for the next 1-2 weeks so between that and remote work I might not be as quick on this as I was before - but I'll try and find some time |
I am using tarpaulin with coveralls.io. coveralls supports viewing coverage on branches. However, coverage data generated from runs on branches does not get recognized correctly:
GitHub actions workflow
Expected outcome
In this scenario, I'd expect the branch name and commit message data to be submitted to coveralls correctly. Am I doing something wrong with my command invocation?
The text was updated successfully, but these errors were encountered: