Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cross-platform snprintf #4

Closed
willyd opened this issue Aug 18, 2015 · 4 comments
Closed

Implement cross-platform snprintf #4

willyd opened this issue Aug 18, 2015 · 4 comments

Comments

@willyd
Copy link
Owner

willyd commented Aug 18, 2015

Windows does not have snprintf:

See this PR for possible implementation
BVLC#2084

Otherwise maybe we can use #define s like in gtest_all.cc

@lunzueta
Copy link
Collaborator

According to this discussion (http://stackoverflow.com/questions/2915672/snprintf-and-visual-studio-2010) the possible solutions to this in Windows depend on the Visual Studio version used. I guess that it is necessary to specify which would be the minimal VS version that should be used for Caffe.

Besides, I guess that MinGW should also be taken into account and not only Visual Studio, but I'm not familiar to it. Here some comments about this:
http://sourceforge.net/p/mingw-w64/mailman/message/31241434/

@bhack
Copy link

bhack commented Aug 18, 2015

@eelstork
Copy link

eelstork commented Dec 7, 2015

Fixed on master (see BVLC#3361)

@willyd
Copy link
Owner Author

willyd commented Dec 11, 2015

Closing fixed by: BVLC#3361

@willyd willyd closed this as completed Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants