Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePickerModal - Darker primary color on web makes action button unreadable #457

Open
jennifer-dickinson opened this issue Mar 5, 2025 · 1 comment
Labels
bug Something isn't working repro provided Reproducible example provided

Comments

@jennifer-dickinson
Copy link

jennifer-dickinson commented Mar 5, 2025

Current behaviour

When using web to preview the date picker modal and using an MD2 theme, if the theme primary color is a darker shade, the icon buttons on the modal are not visible.

Expected behaviour

The buttons should be visible regardless of platform.

How to reproduce?

  1. Have a light theme with a darker primary color such as #0f48a3
  2. Preview the app using web
  3. Open the date picker modal
  4. Observe the action buttons are not legible

Snack: https://snack.expo.dev/@jvsalas/date-picker-button-color-issue?platform=web

Preview

Image

What have you tried so far?

Unable to tweak theme further in date picker modal.

Your Environment

software version
react-native-paper-dates 0.22.34
react-native-paper 5.13.1
expo sdk 52
@jennifer-dickinson jennifer-dickinson added the bug Something isn't working label Mar 5, 2025
@iM-GeeKy
Copy link
Collaborator

iM-GeeKy commented Mar 8, 2025

PRs are welcome!

@iM-GeeKy iM-GeeKy added the repro provided Reproducible example provided label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working repro provided Reproducible example provided
Projects
None yet
Development

No branches or pull requests

2 participants