Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualenv detection regression #1554

Open
nickbabcock opened this issue Aug 18, 2019 · 1 comment
Open

Virtualenv detection regression #1554

nickbabcock opened this issue Aug 18, 2019 · 1 comment

Comments

@nickbabcock
Copy link

nickbabcock commented Aug 18, 2019

Prior to #1412 one could use any virtual environment manager (introduced by #863). Now #1412 clamps down on this flexibility. Even if one has a virtualenv with all of algo's dependencies installed (through pipenv / poetry / something else) the ./algo script will fail. I'm unsure if there is a perfect solution, as the use case in #1412 (having a wrong virtualenv activated) is fundamentally at odds with #863 (allowing any virtualenv). I believe the algo maintainers will need to decide what is more important, but I wanted to bring this up as it is a regression that users may run into.

To Reproduce

Steps to reproduce the behavior:

pip install --user pipenv
pipenv install -r requirements.txt
pipenv run ./algo

Results in:

env/bin/activate not found.  Did you follow documentation to install dependencies?

Expected behavior

Used to work just fine

@jackivanov
Copy link
Collaborator

jackivanov commented Aug 22, 2019

Thank! I've reverted the PR, let's stay with this solution until we rethink it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants