Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talisman breaks when gitconfig.diff.noprefix=true #379

Closed
revolunet opened this issue Jul 27, 2022 · 0 comments · Fixed by #399
Closed

talisman breaks when gitconfig.diff.noprefix=true #379

revolunet opened this issue Jul 27, 2022 · 0 comments · Fixed by #399

Comments

@revolunet
Copy link
Contributor

Describe the bug
Talisman 1.28.0 (and below) silently fails if you have this setting in your ~/.gitconfig:

[diff]
  noprefix = true

To Reproduce
Add the GIT setting, try to to run talisman pre-commit hook

This result in :

Talisman Scan: 0 <...........................................................................................................................................................................................................................................................................> ?%
Talisman done in 68.989268ms
 TALISMAN >>>>   Check passed!!!!

You can see the progressbar is broken (?%) that's because talisman cant handle the git diff output

Also, errored files are not detected and commited

Expected behavior

Talisman should detect or override such userland setting or warn the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant