fix(fetchVotingEvidences api): reset votingResult any time it is recalculated

Make sure that the calculation of votingResult resuts the result each time it is performed

Author: EnricoPicci

src/api/voting-event-apis.ts

@@ -393,13 +393,11 @@ export function fetchVotingEvidences(
                     const techId: any = t._id;
                     return techId.toHexString() === id;
                 });
+                tech.votingResult = {
+                    votesForRing: [],
+                };
                 const votesGroupedByRing = groupBy(votes, 'ring');
                 Object.entries(votesGroupedByRing).forEach(([ring, votes]) => {
-                    if (!tech.votingResult) {
-                        tech.votingResult = {
-                            votesForRing: [],
-                        };
-                    }
                     tech.votingResult.votesForRing.push({ ring, count: votes.length });
                 });
                 const votesGroupedByTag = new Map<string, Vote[]>();

src/mongodb/voting-event-apis.spec.ts

@@ -1221,6 +1221,23 @@ describe('Operations on votingevents collection', () => {
                     expect(t1.votingResult.votesForRing[0].count).to.equal(2);
                     expect(t1.votingResult.votesForTag).to.be.undefined;
                 }),
+                // We move to the third step and want to check that the voting results are the same at least in terms of numbers
+                concatMap(() => mongodbService(cachedDb, ServiceNames.moveToNexFlowStep, { _id: votingEventId })),
+                concatMap(() => mongodbService(cachedDb, ServiceNames.getVotingEvent, votingEventId)),
+                tap((votingEvent: VotingEvent) => {
+                    expect(votingEvent.round).to.equal(votingEventRound + 2);
+                    const t0 = votingEvent.technologies.find(t => t.name === tech0.name);
+                    expect(t0.votingResult.votesForRing.length).to.equal(1);
+                    const productionTagRes = t0.votingResult.votesForTag.find(t => t.tag === productionTag);
+                    expect(productionTagRes.count).to.equal(2);
+                    const trainingTagRes = t0.votingResult.votesForTag.find(t => t.tag === trainingTag);
+                    expect(trainingTagRes.count).to.equal(2);
+                    const colleaguesTagRes = t0.votingResult.votesForTag.find(t => t.tag === colleaguesTag);
+                    expect(colleaguesTagRes.count).to.equal(2);
+                    const t1 = votingEvent.technologies.find(t => t.name === tech1.name);
+                    expect(t1.votingResult.votesForRing.length).to.equal(1);
+                    expect(t1.votingResult.votesForTag).to.be.undefined;
+                }),
             )
             .subscribe(
                 null,