Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nested lists in markdown render slightly mismeasured #647

Closed
alixander opened this issue Jan 11, 2023 · 3 comments · Fixed by #665
Closed

nested lists in markdown render slightly mismeasured #647

alixander opened this issue Jan 11, 2023 · 3 comments · Fixed by #665
Labels
bug Something isn't working

Comments

@alixander
Copy link
Collaborator

alixander commented Jan 11, 2023 •
edited
Loading

probably some padding/margin we aren't factoring in when a nested list appears.

https://play.d2lang.com/?script=4qqwUqjJTeFSUFBWyEit5FJQ0FUogTAUFAz1IOwaLkAAAAD__w%3D%3D&

also, only with headers? weird

notice the "y"

Screen Shot 2023-01-11 at 11 05 47 AM
@alixander alixander added the bug Something isn't working label Jan 11, 2023
@cyborg-ts cyborg-ts added this to D2 Jan 11, 2023
@alixander alixander mentioned this issue Jan 11, 2023
Closed
@gavin-ts gavin-ts mentioned this issue Jan 14, 2023
Merged
@github-project-automation github-project-automation bot moved this to Done in D2 Jan 16, 2023
@vfosnar
Copy link
Contributor

vfosnar commented Feb 19, 2023 •
edited
Loading

@alixander looks like it's broken again?

@alixander
Copy link
Collaborator Author

@vfosnar where's the breakage? can you screenshot what you're seeing?

@vfosnar
Copy link
Contributor

vfosnar commented Feb 19, 2023

Oh, looks like it's broken in FF but works in chromium.

Firefox (110.0 64-bit)

image

Also connections are for some reason not showing on the screenshot but are in fact rendered.

Chromium (Brave Version 1.48.164 Chromium: 110.0.5481.100 64-bit)

20230219_16h12m48s_grim

@alixander alixander mentioned this issue Feb 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
D2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

render: fixing markdown li measurement gavin-ts/d2
2 participants
@alixander @vfosnar