Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further align with @typescript-eslint/types #7

Open
manuel3108 opened this issue Mar 6, 2025 · 0 comments
Open

Further align with @typescript-eslint/types #7

manuel3108 opened this issue Mar 6, 2025 · 0 comments

Comments

@manuel3108
Copy link
Member

This is an awesome start bc39dcb but sadly there a a few more places that don't match.

A good start would be by having a look at the latest esrap version (or more specifically this pr), and go through the few ignored type-check warnings.

Here is a list of what's currently not entirely correct according to the sepc:

Type property is property should be
TSTypeParameter (property name) typeof string typeof Identifier
TSFunctionType parameters params
TSFunctionType typeAnnotation.typeAnnotation typeParameters
TSMethodSignature parameters params
TSMethodSignature typeAnnotation typeParameters

This is an incomplete list of course. There are also two or there more type errors inside esrap that might be related to this, or to wrong type expectations in esrap. I have excluded those cases in the list above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant