Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

feat(lambda-at-edge): support fallback: false for getStaticPaths and fix cache-control header #681

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

dphang
Copy link
Collaborator

@dphang dphang commented Oct 15, 2020

Fixes/closes: #673

Also adds proper cache-control header so that CloudFront can cache the responses including the 404 page.

@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #681 into master will decrease coverage by 0.11%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   79.29%   79.17%   -0.12%     
==========================================
  Files          52       52              
  Lines        1608     1618      +10     
  Branches      338      345       +7     
==========================================
+ Hits         1275     1281       +6     
  Misses        277      277              
- Partials       56       60       +4     
Impacted Files Coverage Δ
...ackages/libs/lambda-at-edge/src/default-handler.ts 94.39% <69.23%> (-1.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9910a0...6ee0ea9. Read the comment docs.

@dphang dphang merged commit 3ef5c17 into master Oct 15, 2020
@delete-merged-branch delete-merged-branch bot deleted the dphang/fallback-false branch October 15, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic route at pages level leds request for public resources to 503 Error
1 participant