Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow storage of AccessKeys in external secret manager (i.e. OpenBao, HashiCorp Vault) #2749

Open
jandd opened this issue Feb 17, 2025 · 1 comment
Labels

Comments

@jandd
Copy link

jandd commented Feb 17, 2025

Related to

Ansible (task execution)

Impact

security improvements

Missing Feature

It would be nice to be able to let semaphore use an external credential manager like OpenBao or HashiCorp Vault for secrets like SSH private keys, Ansible vault secrets and passwords. This would improve the security for the case that an attacker gets access to a backup of a machine running Semaphore UI. The attacker would not be able to use the credentials without access to the external secret manager.

Implementation

From my point of view the AccessKey struct in db/AccessKey.go needs an abstraction to retrieve the keys from an external secret manager or from the current implementation as a fallback. Configuration needs to be extended to configure the secret manager API endpoint as well as credentials (Token, Approle or potential other ways to authenticate against the secret manager).

Design

No response

@jandd jandd added the feature label Feb 17, 2025
@nicholasleejk
Copy link

To add on to the list, maybe cloud native secret managers like AWS Secrets Manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants