Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osgi dependency on logback should be optional #391

Closed
schallee opened this issue Sep 8, 2015 · 2 comments
Closed

Osgi dependency on logback should be optional #391

schallee opened this issue Sep 8, 2015 · 2 comments
Labels
enhancement

Comments

@schallee
Copy link
Contributor

schallee commented Sep 8, 2015

Greetings, the maven-bundle-plugin is adding logback to the list of imported packages. These should be changed to optional imports as from what I read other places and the code that uses logback, logback is optional.

I'll submit a pull request with this issue once I figure out how.
@schallee
Copy link
Contributor Author

schallee commented Sep 8, 2015

Pull request is #392

@sarxos
Copy link
Owner

sarxos commented Sep 8, 2015

Thanks @schallee! Pull request has been merged.

@sarxos sarxos closed this as completed Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarxos @schallee